Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system("android") per configuration #1062

Merged
merged 1 commit into from
May 7, 2018
Merged

Allow system("android") per configuration #1062

merged 1 commit into from
May 7, 2018

Conversation

redorav
Copy link
Collaborator

@redorav redorav commented Apr 17, 2018

No description provided.

@redorav
Copy link
Collaborator Author

redorav commented May 5, 2018

Are there any objections to this, am I missing anything? I'm hesitant to press the "Update branch" button since @TurkeyMan has complained about how it pollutes the history. When I did this PR it wasn't behind master but now it's many commits behind. Does one need to rebase and resubmit PR every time it goes out of sync with master?

@TurkeyMan
Copy link
Contributor

Yeah, I'm not sure what the right process is anymore. That "Update branch" button is the spawn of satan... but to avoid it, you need admin privileges!
I can't believe Github thought this was okay :/
I hope Github are aware they're idiots, and making options to configure this flow for projects.

@TurkeyMan TurkeyMan merged commit 968fc11 into premake:master May 7, 2018
@pdoane
Copy link

pdoane commented May 7, 2018

Yeah, I'm not sure what the right process is anymore. That "Update branch" button is the spawn of satan... but to avoid it, you need admin privileges!

It's a part of the branch protection settings so it can be controlled per-branch/per-repository as to whether code needs to be up to date.

@redorav redorav deleted the android_config branch May 8, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants