Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing DebugInformationFormat when symbols are set to full #1087

Merged
merged 1 commit into from
May 15, 2018

Conversation

rorydriscoll
Copy link
Contributor

When symbols are set to "full" then the DebugInformationFormat attribute is not emitted no matter what the other settings are. For me, this manifested itself as the editandcontinue function appearing not to work.

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be worth changing this function to be a little less verbose one day. if cfg.symbols == p.OFF then and then if cfg.symbols then seems like it would be better than having to list all of the "On" or "Off" values.

@samsinsane samsinsane merged commit 4e14522 into premake:master May 15, 2018
@rorydriscoll
Copy link
Contributor Author

It would be less error prone to explicitly list out the default case too and make the final else emit an error. That would have saved me a couple of hours. In another language this would be a switch statement with an error in the default case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants