gmake2: Remove pch from FORCE_INCLUDE to allow NoPCH per-file #1100
Conversation
| end | ||
|
|
||
| if path.iscfile(file.name) then | ||
| return 'ALL_CFLAGS' | ||
| if fcfg and fcfg.flagsVariable then |
There was a problem hiding this comment.
I'm not entirely sure what flagsVariable is, why that would override the $(ALL_*FLAGS) flag, or how it's related to PCH files?
There was a problem hiding this comment.
This is the per-file arguments variable name.
With gmake2, if files have specific arguments, the generator will create a Makefile var PERFILE_FLAGS_* to group them.
As an example, You can have this:
PERFILE_FLAGS_0 = $(ALL_CXXFLAGS) -mf16c
then your file rule will be
$(SILENT) $(CXX) $(PERFILE_FLAGS_0) $(FORCE_INCLUDE) -o "$@" -MF "$(@:%.o=%.d)" -c "$<"
instead of
$(SILENT) $(CXX) $(ALL_CXXFLAGS) $(FORCE_INCLUDE) -o "$@" -MF "$(@:%.o=%.d)" -c "$<"
The way it is implemented is that ALL_*FLAGS is contained in PERFILE_FLAGS_* if necessary so it doesn't need to be added as well.
There was a problem hiding this comment.
I do remember seeing those, this makes sense - thanks for that!
|
Yeah, completely forgot unit tests. I will implement some later today. |
No description provided.