Fix gmake2 #1108
Merged
Fix gmake2 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/gmake2/gmake2_utility.lua
Outdated
| function utility.exepaths(cfg, toolset) | ||
| local dirs = project.getrelative(cfg.project, cfg.bindirs) | ||
| if #dirs > 0 then | ||
| p.outln('EXE_PATHS = export PATH=$(EXECUTABLE_PATHS):$$PATH;') |
There was a problem hiding this comment.
EXE_PATHS = export PATH=$(EXECUTABLE_PATHS):$$PATH;
wouldn't it make more sense to be this:
EXE_PATHS = PATH=$(EXECUTABLE_PATHS):$$PATH
seeing the implementation here:
_p('\t$(SILENT) $(EXE_PATHS) %s', cmd)
?
bindirs are added to make files for gmake2
tvandijck
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindirs are added to make files for gmake2