Fix Xcode autocompletion with excluded files #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, files are added to the exclude list on all configurations, which disables autocompletion on Xcode. If a file is just excluded in some configurations it's handled the old way.
TurkeyMan
approved these changes
Jun 25, 2018
samsinsane
requested changes
Aug 10, 2018
modules/xcode/xcode_project.lua
Outdated
| if value == nil then | ||
| value = newValue | ||
| elseif value ~= newValue then | ||
| print("WARNING: " .. node.name .. " is excluded in just some configurations. Autocompletion will not work correctly on this file in Xcode.") |
There was a problem hiding this comment.
This should probably use p.warn instead?
There was a problem hiding this comment.
Ok, changed.
samsinsane
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode's autocompletion gets disabled when a file is added to the exclude list. Unfortunately, the compilation units module adds the ExcludeFromBuild flag to all the source files, and the Xcode module translates it into adding them to the Xcode exclude list.
This commit checks if a file must be excluded in all the configurations and in that case it removes the file from the target, so there's no need to add it to any exclusion list (letting Xcode index the file). In case a file is excluded in just some configurations, it prints a warning and keeps the old behavior for that file.