Fix gmake multiple-output rule issue. #1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules with multiple outputs were emitting rules in the form:
Which is incorrect, because it will execute the rule many times (once for each output).
I think it's intended to describe that a rule produces multiple outputs, and this patch improves the modelling of that relationship in make to read like:
This isn't the best implementation, but it's not just plain broken, and others are much more complicated.
I left some TODO notes for future improvement.