Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gmake multiple-output rule issue. #1137

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

TurkeyMan
Copy link
Contributor

Rules with multiple outputs were emitting rules in the form:

a b c: src
  build src -o a b c

Which is incorrect, because it will execute the rule many times (once for each output).

I think it's intended to describe that a rule produces multiple outputs, and this patch improves the modelling of that relationship in make to read like:

a: src
  build src -o a b c
b c: a

This isn't the best implementation, but it's not just plain broken, and others are much more complicated.

I left some TODO notes for future improvement.

@samsinsane samsinsane merged commit 4a47c3e into premake:master Aug 10, 2018
@TurkeyMan TurkeyMan deleted the multi_output_deps branch December 5, 2018 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants