Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix objname collisions #1191

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix objname collisions #1191

merged 1 commit into from
Nov 12, 2018

Conversation

ratzlaff
Copy link
Contributor

@ratzlaff ratzlaff commented Nov 10, 2018 •
edited
Loading

Tweaks logic for setting the sequence number during baking so that objname's are unique on a per-configuration / project basis.

Should resolve #1187
Should resolve #1182

@ratzlaff ratzlaff force-pushed the fix_obj_collisions branch 2 times, most recently from 76c8d78 to 793002f Compare November 10, 2018 05:59
samsinsane
samsinsane approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally prefer to use the path of the object instead of appending arbitrary numbers on the end, but it's not a huge problem - having a functioning solution is much more important.

@tdesveauxPKFX tdesveauxPKFX merged commit 491051a into premake:master Nov 12, 2018
@ratzlaff ratzlaff deleted the fix_obj_collisions branch November 12, 2018 23:46
This was referenced Sep 5, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsinsane samsinsane samsinsane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ratzlaff @samsinsane @tdesveauxPKFX