Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Visual Studio 2019 solutions #1258

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Added support for Visual Studio 2019 solutions #1258

merged 1 commit into from
Apr 4, 2019

Conversation

CosmicRey
Copy link
Contributor

Uses new action vs2019

@fsfod
Copy link

fsfod commented Mar 17, 2019

I guess you beat me to punch to get a PR up for this https://github.com/fsfod/premake-core/commits/vs2019. You can just take any of my changes if you want for this PR most of them are same as yours.
I was just diffing between Visual Studio generated console projects between 2017 and 2019 for most of what i figured out. Something i did miss was the the ToolsVersion attribute changed to "Current" for vcxproj.user files instead of "15" idk how much it really matters to visual studio through.

@CosmicRey
Copy link
Contributor Author

Awesome thanks, I'll take a look!

samsinsane
samsinsane requested changes Mar 18, 2019
View reviewed changes
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few issues to be resolved/discussed before this can be merged. Thanks for taking the time to submit this, hopefully we can get this all sorted out before the official release date.

modules/vstudio/tests/vc2010/test_globals.lua Outdated Show resolved Hide resolved
modules/vstudio/vs2010_vcxproj.lua Show resolved Hide resolved
modules/vstudio/vs2010_vcxproj_user.lua Outdated Show resolved Hide resolved
modules/vstudio/vs2019.lua Show resolved Hide resolved
modules/vstudio/tests/fs2005/projectsettings.lua Outdated Show resolved Hide resolved
@CosmicRey
Copy link
Contributor Author

@samsinsane Just pinging to see if there is anything else needed.

@WorldofBay
Copy link
Contributor

WorldofBay commented Mar 27, 2019 •
edited
Loading

lgtm but if you want to fulfill style things i'd have 3 little things:

  • end tables with comma so that future edits are easily copypastable/single-line changes (modules/vstudio/_manifest.lua)
  • maybe for the same reason add an 'or false' in modules/vstudio/_preload.lua:
_ACTION == "vs2019" or
false;
  • there is no trailing newline in modules/vstudio/tests/vc2010/test_header.lua

however, those are not necessary, just nice to have

at the very end you should squash your commits when you're ok then sam will merge once he's got the time :)

@ratzlaff ratzlaff mentioned this pull request Mar 27, 2019
Closed
@CosmicRey CosmicRey force-pushed the master branch 2 times, most recently from 74f0f70 to 609450c Compare March 30, 2019 19:22
@CosmicRey
Added support for Visual Studio 2019 solutions
d152f0e 
Added tests for new action
Changed how vs2019 aquires latest target Platform

Added optional userToolsVersion to vstudio
@samsinsane samsinsane merged commit 53dfe1e into premake:master Apr 4, 2019
@Aodai Aodai mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsinsane samsinsane samsinsane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CosmicRey @fsfod @WorldofBay @samsinsane @ninja-on-rye