Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the 'visibility' API for Android projects #1266

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Implement the 'visibility' API for Android projects #1266

merged 1 commit into from
Apr 8, 2019

Conversation

ifarbod
Copy link
Contributor

@ifarbod ifarbod commented Apr 5, 2019

As discussed in #1251 (comment)

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please squish the commits and I'll merge.

@ifarbod
Copy link
Contributor Author

ifarbod commented Apr 8, 2019

@samsinsane There's the "Squash and merge" option on the dropdown next to the Merge button - that way it doesn't need a force push.
But sure, I'll squash them anyway.

@samsinsane samsinsane merged commit 1510109 into premake:master Apr 8, 2019
@ifarbod ifarbod deleted the android-visibility-hidden branch April 8, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants