Fix the return value of some os functions #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp-jordi-vilalta
force-pushed
the
feature/fix-os-return
branch
from
db4deb5
to
75ceeb5
Compare
starkos
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the return values for os.rmdir and os.remove so they're consistent with the Premake documentation and the standard Lua ones.
How does this PR change Premake's behavior?
These functions now report some status that wasn't reported before, so the user can check it if needed. It was confusing not getting any result values in some cases, specially in a function that overrides the standard Lua library.
Anything else we should know?
I've just tested my changes on macOS. The test suite passes but I'm not sure if there may be anything that relies on the previous behavior (now there are some shortcuts when something can't be removed).
I also added a tiny mostly-unrelated commit to fix some comments on related files, I hope it's okay to have it here.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)