Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkFunc from Resource files #1402

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

yuyoyuppe
Copy link
Contributor

What does this PR do?

This is a second attempt at fixing 1172. I've removed the function entirely according to @starkos comment.

How does this PR change Premake's behavior?

Are there any breaking changes? Will any existing behavior change?

  • .rc files are now included by default for non-windows systems

Add any other context about your changes here.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Follow our coding conventions
  • Minimize the number of commits

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the two comments this seems good to me.

modules/vstudio/tests/vc2010/test_files.lua Outdated Show resolved Hide resolved
modules/vstudio/tests/vc2010/test_files.lua Outdated Show resolved Hide resolved
@samsinsane samsinsane merged commit 0a98448 into premake:master Feb 18, 2020
@yuyoyuppe yuyoyuppe deleted the fix_1172 branch February 9, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants