Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1411: Remove "|" from Codelite config names #1419

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

starkos
Copy link
Member

@starkos starkos commented Mar 30, 2020

What does this PR do?

Fix #1411 by removing the pipe symbol "|" from Codelite configuration names.

How does this PR change Premake's behavior?

The configuration names will now appear as "platform-config" e.g. "x86-Debug" instead of the previous "x86|Debug". Note this only happens if the workspace has specified platforms.

Anything else we should know?

See #1411 for discussion about the fix.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane samsinsane merged commit 7cad09e into premake:master Mar 31, 2020
@starkos starkos deleted the fix/issue-1411 branch April 6, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeLite Generation Broken, Breaks with Multiple Platforms
2 participants