Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Gets Premake's bootstrap makefile to work properly with MinGW (64-bit only). This is an attempt to resurrect PR #1111.
Closes #559.
How does this PR change Premake's behavior?
A few additions were made to Premake to improve support for MinGW specifically. Those were added by @tdesveauxPKFX in #1111, I've maintained them as is.
Anything else we should know?
I've successfully built Premake using the 64-bit version of MinGW using these changes. I was not able to build with the 32-bit version, though that may have been a local setup issue; I didn't pursue it. Since, best I could tell, we aren't currently able to build with MinGW at all this seems like an incremental win.
I left @tdesveauxPKFX's commits intact so he would get some credit for the fix, since he did the bulk of the work on this one.
Two unit tests fail with the MinGW build:
base_os.remove_ReturnsTrue_OnFile
gets an "Access denied" error when it tries to delete a temporary filepremake_binmodules.testExample
fails with "module 'example' not found"Did you check all the boxes?
Add unit tests showing fix or feature works; all tests pass(minimal code changes)Mention any related issuesYou can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!