Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ability to override XCode generator #1481

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

samsinsane
Copy link
Member

What does this PR do?

Makes it much easier to override various parts of the XCode generator without copying half of the xcode_common.lua file.

How does this PR change Premake's behavior?

No breaking changes. No existing behaviour will change.

Anything else we should know?

Removed an unused function.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane samsinsane requested a review from starkos July 10, 2020 13:58
Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start!

@starkos starkos merged commit cb81269 into premake:master Jul 10, 2020
@samsinsane samsinsane deleted the ssurtees/xcode branch July 11, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants