Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Artifacts #1499

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

Timic3
Copy link
Contributor

@Timic3 Timic3 commented Aug 19, 2020

What does this PR do?

This pull request uploads binary files after pipeline is finished and can be downloaded afterwards.

How does this PR change Premake's behavior?

No.

Anything else we should know?

This puts all files from bin/[release,debug] folder to a Zip file and uploads it to Actions server.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I was looking at doing this a couple weeks ago and completely forgot haha!

Just a few changes. Also, I don't think it's necessary to upload the debug builds, but happy for this to be reviewed at a later date.

.github/workflows/ci-workflow.yml Outdated Show resolved Hide resolved
.github/workflows/ci-workflow.yml Outdated Show resolved Hide resolved
@Timic3
Copy link
Contributor Author

Timic3 commented Aug 20, 2020

Thanks for the review, regarding the debug builds, I totally agree, they are also rather big (twice the size), so it would be best to remove them (they can of course be added back, if there is a need for them). With that said, I guess there is no need for matrix.config in the artifact names then? Or should I leave them there?

@samsinsane
Copy link
Member

That's a good question, I hadn't really thought about it - I don't think it really matters either way, I'm happy with whatever you decide.

@samsinsane
Copy link
Member

Thanks for this!

@samsinsane samsinsane merged commit 75c74f2 into premake:master Aug 21, 2020
@Timic3 Timic3 deleted the feature/actions-artifacts branch August 21, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants