Fix quote escaping in Codelite. #1506
Conversation
-> fix define with quote -> fix SharedLib (at least on windows).
| @@ -40,7 +40,7 @@ | |||
| local result = value:gsub('&', '&') | |||
| result = result:gsub('<', '<') | |||
| result = result:gsub('>', '>') | |||
| result = result:gsub('"', '\\"') | |||
| result = result:gsub('"', '"') | |||
There was a problem hiding this comment.
I'm a bit hesitant to approve this, the \ was required. Does the Premake project still build with CodeLite with this change?
There was a problem hiding this comment.
For me adding extra \ breaks defines with quotes and sharedLib (on windows).
premake project doesn't use either so it is identical for it.
It is the downside of simple UTs without integration testing ;-)
With my sample project, I now have
-shared;-Wl,--out-implib="bin/Debug/sharedLib.lib"
("C:/msys64/mingw64/bin/x86_64-w64-mingw32-g++.exe" -shared -fPIC -o bin/Debug/sharedLib.dll @"sharedLib.txt" -LC:\msys64\mingw64\lib -L. -shared -Wl,--out-implib="bin/Debug/sharedLib.lib"
)
instead of previous
-shared;-Wl,--out-implib=\"bin/Debug/sharedLib.lib\"
(``"C:/msys64/mingw64/bin/x86_64-w64-mingw32-g++.exe" -shared -fPIC -o bin/Debug/sharedLib.dll @"sharedLib.txt" -LC:\msys64\mingw64\lib -L. -shared -Wl,--out-implib="bin/Debug/sharedLib.lib" ) with cannot create `"bin/Debug/sharedLib.lib"` (quote in name of file).
Moreover, it makes sense to not have to escape " which already mean quote (which might be string delimiter or inside string).
There was a problem hiding this comment.
premake project doesn't use either so it is identical for it.
It does, can you answer my question now?
There was a problem hiding this comment.
I see no problem here.
What does this PR do?
Fix quote escaping in Codelite.
-> fix define with quote
-> fix SharedLib (at least on windows).
improve/fix #1275
How does this PR change Premake's behavior?
No Core changes, only codelite generator
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)