Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useFullPaths config property for Visual Studio projects #1571

Merged
merged 1 commit into from
Dec 24, 2020
Merged

useFullPaths config property for Visual Studio projects #1571

merged 1 commit into from
Dec 24, 2020

Conversation

cos-public
Copy link
Contributor

What does this PR do?

Supports usefullpaths configuration property, which controls /FC compiler option.

How does this PR change Premake's behavior?

Support new configuration property.

Anything else we should know?

The property is supported by Visual Studio since 2010 https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/027c4t2s(v=vs.100), so tests are not version-specific.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Comment on lines +1510 to +1514
if cfg.useFullPaths then
m.element("UseFullPaths", nil, "true")
else
m.element("UseFullPaths", nil, "false")
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced with:

Suggested change
if cfg.useFullPaths then
m.element("UseFullPaths", nil, "true")
else
m.element("UseFullPaths", nil, "false")
end
m.element("UseFullPaths", nil, iif(cfg.useFullPaths, "true", "false"))

@samsinsane samsinsane merged commit 9b8b035 into premake:master Dec 24, 2020
@nepp95 nepp95 mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants