-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new website with docs with docusaurus #1587
Conversation
Looks absolutely fantastic, you've done a great job with this. Curious: why are 4.x docs are under I do prefer having each library ( Here's a question…at some point we may need to track development of a v5.x and a v6.x. Those would probably maybe be on separate branches, and would stay on separate branches so we could keep maintaining v5? Not sure how we would track the documentation in that setup. Maybe we just publish from the latest (v6) branch? Something that we might need to address but I don't see any reason to let it hold this up. Again, great work with this! I'd like to get feedback from @samsinsane but atm I see no reason not to land this and start redirecting the wiki pages over to here. Are you cool with landing this PR as is and then iterating on the content, or are you intending to do more work on it first? |
Thanks for your feedback! I really appreciate it.
It's all about URLs. Docs in
And from this moment link
In general, website should have only one version (the published one). If we started development of a 6.x on a separate branch then docs would need to be maintained on master in order for them to be published. It's still possible to maintain 6.x docs on a branch and merge webite into master later.
Yes, this PR is intended to be merged so other people can be involved in docs migration :-) |
Playing around with this some more…
Would it be possible for you to clean up the 4.x stuff? In the meantime I'll ping @samsinsane; if he has no objections I'd like to get this landed this week, and then I'll go head down on migrating the docs and see if I can't crank through it. I'd prefer not to go live until we have the majority of the content moved over, and I'd like to get this live ASAP. |
Oh yeah…the website is served from a different repository—I assume we can set up the deployment action to push the results there? |
Sure thing. But you said "try to maintain two separate collections". Actually the idea of versioned docs is that we maintain only one (current/latest/next) version of docs. Old historical API shouldn't be modified (at least not often, in theory ofc). I understand your point of view. Sections "Availability" look nice IMO but what about people using Premake4 who want to find functions for their version only?
Yes, I'll do it as soon as I can. Just clarify for me one thing. What should be left on the website: docs for 5.0 or just simply "docs" without version specified?
Yes exactly. We will use GitHub Action in this repo to build static files and then automatically push them to the other repo. It's simple configuration, I've done it a few times already. |
v4 has its own repository and wiki. I'd prefer to focus on getting v5 ported over and cleaned up ASAP, so I can get back to everything else. If someone else feels like migrating the v4 docs after the fact I'm not opposed to it, but it doesn't seem necessary.
Let's go with just "docs" for now. Once I have a better idea of where the in-development code is going to land I can make changes if needed, but I don't expect it will be necessary. Thanks again for taking the lead on this. |
hey, please add this to our showcase :) |
when it's ready, sure :-) Ok, I removed all 4.x stuff. There is only one version of docs on the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I haven't looked at this sooner, it looks good to me.
Okay, I think we're good to go then. @KyrietS do you agree? |
Yes. Merge it and let the migration begin 👍 |
Done. If you (or anyone) is planning to migrate documentation, let's coordinate over on #1547. |
Website with docs for Premake 4.x and 5.0
This idea is discussed in #1547
Structure
Whole website is stored in folder
website
(followed convention from Docusaurus wiki). Docs for Premake 5.0 are stored in markdown files inwebsite/docs
. Some minimal changes have to be done for files downloaded from current github-wiki docs.I've added many examples in this commit so it's easy to understand everything (I hope).
Example is temporarily hosted on my repo: https://kyriets.github.io/premake-core/
Building website
read
website/README.md
tl;dr
(Node.js with npm needed)
Building website with GitHub Actions
Example here
Migration / editor notes
```lua
).```bash
.```lua {3}
.**inlineCode()**
to`inlineCode()`
.**bold text**
is overused. In many places`inline mono`
should be used instead.id:
defaults to filename andtitle:
defaults toid
if not provided. So instead of creating front matter in fileos.mkdir.md
like this:it's better not to provide front matter at all. (
id
is used to create link in sidebar)website/static
folder so they can be referenced with global path, eg. we have an image in/website/assets/img/image.png
and if you want to include this image in docs page you should write:![alt text](/img/image.png)
. There is no/assets/
before image path! It'll be added by Docusaurus automatically./website/docs/Style-Guide.md
that showcases all markdown features in Docusaurus. This page is not listed in sidebar. It's quite useful, especially when you modify theme and styles.os
prefix (os.mkdir, os.rmdir, etc.) are grouped in sidebar. I'm not sure if we want this./website/src/pages/download.md
is work-in-proggress. It's also an exmaple of how you can add another page to the website.