add RemoveUnreferencedCodeData option to disable /Zc:inline #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starkos
requested changes
Apr 4, 2021
There was a problem hiding this comment.
We've just recently rolled out a new website that allows the documentation to be stored in the main repository. Would it possible to add a documentation page for this new method? Just copy from one of the pages inwebsite/docs and then add it to website/sidebar.js in alpha order. You would need to rebase against the latest changes to see the new site files (which will help getting this merged as well).
|
Done! I hope I did everything correct, couldn't really preview it. I "guessed" the version it would be available in as alpha 16, hope that was okay :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the option to properly toggle this Visual Studio project build option: https://docs.microsoft.com/en-us/cpp/build/reference/zc-inline-remove-unreferenced-comdat?view=msvc-160
How does this PR change Premake's behavior?
When specifying
removeunreferencedcodedata"On" or "Off",<RemoveUnreferencedCodeData>true</RemoveUnreferencedCodeData>orfalsewill be added to the vcxproj in each build config, similar tousefullpaths.When it is not specified, nothing changes.
Anything else we should know?
By default, Visual Studio assumes this value to be true, when it is not specified. I was annoyed by this (I wanted to replicate compile options from an old project) and decided to add this.
I pretty much just copypasted the usefullpaths behaviour, so I don't expect this to misbehave :)
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!