Fix typo in Using Premake documentation #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
reviewed
Jun 1, 2021
website/docs/Using-Premake.md
Outdated
| @@ -47,7 +47,7 @@ premake5 --help | |||
|
|
|||
| ## Using the Generated Projects | |||
|
|
|||
| For toolsets like Visual Studio and Xcode, you can simply load the generated workspace or workspace into your IDE and build as you normally would. | |||
| For toolsets like Visual Studio and Xcode, you can simply load the generated workspace or workspaces into your IDE and build as you normally would. | |||
There was a problem hiding this comment.
This originally said solution or workspace and during a mass rename of solution to workspace this weirdness was created.
@starkos I feel like this should be reverted back to solution or workspace since those are what is generated, thoughts?
There was a problem hiding this comment.
Agreed, "solution or workspace" was the intended text there. @abhiss Would you be able/willing to adjust your PR?
There was a problem hiding this comment.
Agreed, "solution or workspace" was the intended text there. @abhiss Would you be able/willing to adjust your PR?
Did it. Do I need to merge changes from master?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a typo in documentation to avoid confusion.
How does this PR change Premake's behavior?
Documentation change.
Anything else we should know?
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!