Fix curl header search path #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider curl include directory as system header search path to match #include directives with angle brackets.
samsinsane
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
LGTM, I'll leave this one for @starkos to have a say on before it's merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider curl include directory as system header search path to match #include directives with angle brackets.
What does this PR do?
Fix premake xcode4 project
How does this PR change Premake's behavior?
Nothing. Just allow to generate a correct project to build premake with modern Xcode
Anything else we should know?
Xcode is by default less tolerant regarding mismatch between user header search path (#include "...") and system header search path (#include <...>).
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!