Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use windows-2019 instead of windows-lastest (temporarily) #1820

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

KyrietS
Copy link
Member

@KyrietS KyrietS commented Feb 21, 2022

What does this PR do?

GitHub updated its GH Actions environments and windows-latest is now 2022 by default (previously 2019). It caused our pipeline to fail.
This commit brings back a windows-2019 environment in our GH Actions pipeline.

Anything else we should know?

We will discuss the upgrade back to windows-latest in #1819
Briefly, I would like to use vswhere.exe in our pipeline to avoid hardcoding paths to Visual Studio.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@samsinsane samsinsane merged commit e57f4b7 into premake:master Feb 22, 2022
@KyrietS KyrietS deleted the windows-pipeline-fix branch February 22, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants