Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vswhere.exe in Windows pipeline #1821

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

KyrietS
Copy link
Member

@KyrietS KyrietS commented Feb 23, 2022

What does this PR do?

Use vswhere.exe to get a path to the vcvarsall.bat.
My approach is that I use PowerShell to execute vswhere.exe and save its result to variable ($vcvarsall_path).
Then, run the script in legacy cmd.exe.

Resolves #1819

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for me to review. Can you rebase to latest master and I'll pull it in?

@KyrietS
Copy link
Member Author

KyrietS commented Mar 29, 2022

Rebased on top of master.
Please, don't feel pressured to work fast. We are here because of passion, not duty. Thanks! 😊

@nickclark2016
Copy link
Member

I'm blanking. What merge strategy do we use again? I'm happy with changes

@KyrietS
Copy link
Member Author

KyrietS commented Mar 31, 2022

Do we have a strategy? 😅
I always click the "Merge pull request" button. I know that it creates a redundant merge commit but it has never been a problem. Starkos has always done it this way, so I do doing the same 😁

EDIT:
But if you're asking about who should click the "Merge" button on GitHub then I'm not aware of any rules. Maybe we should have some 😄. I personally try not to merge my own commits but when it's kind-of urgent then I wouldn't hesitate.

@nickclark2016
Copy link
Member

Do we have a strategy? 😅 I always click the "Merge pull request" button. I know that it creates a redundant merge commit but it has never been a problem. Starkos has always done it this way, so I do doing the same 😁

EDIT: But if you're asking about who should click the "Merge" button on GitHub then I'm not aware of any rules. Maybe we should have some 😄. I personally try not to merge my own commits but when it's kind-of urgent then I wouldn't hesitate.

Ahh, talking about merge strategy. Create a Merge Request, Squash and Merge, Rebase and Merge

@KyrietS
Copy link
Member Author

KyrietS commented Mar 31, 2022

Ahh, talking about merge strategy. Create a Merge Request, Squash and Merge, Rebase and Merge

See Premake's commit history. In most cases, we use Create a merge commit. As far as I know, no strategy has been agreed upon

@nickclark2016 nickclark2016 merged commit 00c056c into premake:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows pipeline upgrade to windows-2022
2 participants