-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use vswhere.exe in Windows pipeline #1821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long for me to review. Can you rebase to latest master and I'll pull it in?
0f8726a
to
3c0c0f5
Compare
Rebased on top of master. |
3c0c0f5
to
6cf9509
Compare
I'm blanking. What merge strategy do we use again? I'm happy with changes |
Do we have a strategy? 😅 EDIT: |
Ahh, talking about merge strategy. Create a Merge Request, Squash and Merge, Rebase and Merge |
See Premake's commit history. In most cases, we use Create a merge commit. As far as I know, no strategy has been agreed upon |
What does this PR do?
Use
vswhere.exe
to get a path to thevcvarsall.bat
.My approach is that I use PowerShell to execute
vswhere.exe
and save its result to variable ($vcvarsall_path
).Then, run the script in legacy
cmd.exe
.Resolves #1819
Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!