Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Bug Report Template to add exporter selection #1900

Merged

Conversation

nickclark2016
Copy link
Member

What does this PR do?

Adds a selection for the bug report template to allow users to select the exporter they experience the bug on.

How does this PR change Premake's behavior?

No breaking changes.

Anything else we should know?

This will be useful in the future for more quickly hunting down bugs, especially for tooling with multiple versions supported.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can see benefit to knowing this information, this should already be part of "how can we reproduce this". Perhaps this section should be expanded with more context instead of a new section that splits the information up.

Additionally, a breakdown of exporters (or anything else) should give us more context. Due to the way the VS exporter code is split up, grouping older versions together like this doesn't give us more context. I know why you've done the split like this but it's eliminating the value of asking for the information when it comes to older versions of VS.

.github/ISSUE_TEMPLATE/report-a-bug.md Outdated Show resolved Hide resolved
@nickclark2016
Copy link
Member Author

So it sounds like the course of action is to move the exporters to the "how can we reproduce this section" instead of a new section and adding VS2005 - VS2017 into the options. I just find myself asking this question too often to not have a field for it.

@samsinsane samsinsane merged commit ce5b4af into premake:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants