Fix Codelite/gmake2 buildmessage escaping.
#1913
Conversation
Jarod42
force-pushed
the
fix_buildmessage_escaping
branch
from
efe335b
to
4d38da0
Compare
| @@ -60,7 +60,7 @@ | |||
| value = 0 | |||
| } | |||
|
|
|||
| buildmessage 'Rule-ing %{file.name}' | |||
| buildmessage "Rule'ing %{file.name}" | |||
There was a problem hiding this comment.
Why did - change to '? Seems like an unintended/unnecessary change?
There was a problem hiding this comment.
It was to show/test single quote escaping.
I can revert that part if you prefer.
There was a problem hiding this comment.
That should be done in a dedicated test for escaping, as mentioned in my other comment, as this looks like a typo and will likely end up being changed back eventually.
| @@ -213,15 +213,15 @@ test2.obj: test2.rule | |||
| buildinputs { "toto.txt", "extra_dependency" } | |||
| buildoutputs { "toto.c" } | |||
| buildcommands { "test", "test toto.c" } | |||
| buildmessage "Some message" | |||
| buildmessage '"Some message"' | |||
There was a problem hiding this comment.
You should avoid hijacking existing tests, you should create a new test explicitly for testing the escaping.
There was a problem hiding this comment.
Roll backed.
Dedicated test done.
Jarod42
force-pushed
the
fix_buildmessage_escaping
branch
from
4d38da0
to
8ca0618
Compare
Unrelated to my changes. :-) |
Jarod42
force-pushed
the
fix_buildmessage_escaping
branch
from
8ca0618
to
5b02223
Compare
What does this PR do?
Fix escaping for
buildmessagefor gmake2 and codeliteHow does this PR change Premake's behavior?
Escape double quote and backslash in
quotedAnything else we should know?
Tested with https://github.com/Jarod42/premake-sample-projects/actions with branch custom_rule_check_quote_in_message
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!