-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add address sanitizer flags #1923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're in the process of deprecating flags
and don't allow new values to be added to it, instead can you create a new API? Perhaps sanitize
with the type list:string
- basically the same as flags
just for the sanitizer options.
Removed the |
Anything else need to be changed here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'd say it looks good. As an aside, I see you added "address" sanitizer to GCC (and by proxy clang). What about fuzzer on Clang? It should be supported as well.
Requested changes have been made. |
fuzzer = 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Leaving open for comments by @starkos or @samsinsane (or anyone else) for a few days, then I'll close. Thanks!
Something I just noticed, for consistency with the API, I'll add a follow on to make the arguments lower case to be consistent with the rest of the API. |
Ah, sorry. They were originally flags which use CamelCase so I had followed that pattern. Forgot to change casing when I switched to a new API. |
No worries. I approved the merge, it's on me. |
What does this PR do?
Resolves #1595
fsanitize=address
in gcc, clang, msc, and Visual Studio backends.fsanitize=fuzzer
in msc, Visual Studio, and clang backends.How does this PR change Premake's behavior?
Existing behavior should be unaffected.
Anything else we should know?
There are a number of other
fsanitize
options that are supported by gcc/clang, but not by msc or visual studio. I did not add support for these, but can if it is desired.Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!