Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back pull request #162 #259

Merged
merged 1 commit into from
Sep 10, 2015
Merged

Roll back pull request #162 #259

merged 1 commit into from
Sep 10, 2015

Conversation

starkos
Copy link
Member

@starkos starkos commented Sep 9, 2015

As discussed in the conversion on the request, and on issue #151.

As discussed in the conversion on the request, and on issue premake#151.
@tvandijck
Copy link
Contributor

looks good to me, no objections here... I'll have to investigate if we can get away with it too though.

@starkos
Copy link
Member Author

starkos commented Sep 9, 2015

If you have a use case for setting it, let me know. Best I could tell this was only duplicating what VS was already doing?

@tvandijck
Copy link
Contributor

Yeah, all I know is that we traditionally set it explicitly, but I have no idea what the science behind that is. So I just got to test this on our project and see what the results are. Worst case is that we'll keep this change, since we've always had it. Or we propose a fix where it can optionally be set with a flag, or something else.

starkos added a commit that referenced this pull request Sep 10, 2015
@starkos starkos merged commit fcb06ad into premake:master Sep 10, 2015
@starkos starkos deleted the rollback-162 branch September 10, 2015 20:11
@tritao
Copy link
Contributor

tritao commented Sep 10, 2015

I know I've had problems due to PDB naming issues before and think I even sent a patch related to it in Bitbucket days.. so I'll be on the lookout to see if I hit any issues.

@starkos
Copy link
Member Author

starkos commented Sep 13, 2015

Thanks! I'm happy to change this, but I think we can apply to a narrow set of circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants