Escape string literals passed to defines() for Xcode #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an issue with
defines()in Xcode. If you make a call such asdefines "MY_LITERAL=\"string literal\"", you would expect the result to be-DMY_LITERAL=\"string\ literal\". And indeed, that is the result in a makefile created by the gmake action. Furthermore, in the .xcodeproj, you will even seeGCC_PREPROCESSOR_DEFINITIONS = ( "MY_LITERAL=\"string literal\"", );. However, when Xcode runs the compile command, it ends up being-DMY_LITERAL=string\ literaland compilation fails. With this change, values passed todefines()are escaped in Xcode and it will work equivalently to how it works in gmake.It was possible before to pass a string literal to
defines()for Xcode, but you had to escape it yourself (e.g.,defines "MY_LITERAL=\\\"value\\\""). With this change, it eliminates the special platform check and handling you have to do because the behavior will be consistent. All types of arguments (string literals, numeric values, and names only) passed todefines()appear to function as expected after this change.