Update curl to 7.53.1 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Linux and macOS builds are failing. I'll take a look. |
|
There we go. |
ghost
mentioned this pull request
Merged
|
lgtm PS: We might want to consider submodule'ing curl in the future. |
starkos
approved these changes
Apr 11, 2017
|
@tritao I wish we could, but we hand-crafted our curl_config.h to work for the platforms we currently sort of support.... curl itself when build through ./configure, or cmake generates that file through autoconf like tools... Basically we have 'local' changes to curl that have to be integrated into any updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix an issue where all HTTPS requests on Windows versions older than Windows 8.1 or Windows Server 2012 R2 were failing with the error message "schannel: failed to retrieve ALPN result" (curl/curl#840). Doesn't look like there are any breaking changes as far as I can tell.