Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the deprecated APIs #743

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Clean up the deprecated APIs #743

merged 1 commit into from
Apr 14, 2017

Conversation

starkos
Copy link
Member

@starkos starkos commented Apr 13, 2017

  • Add "Use … instead." messages to any deprecations that did not have one
  • Change deprecation date on APIs without a message to current date
  • Remove APIs that have been deprecated for more than a year

h/t to @samsinsane for original PR on which this is based (#741)

- Add "Use … instead." messages to any deprecations that did not have one
- Change deprecation date on APIs without a message to current date
- Remove APIs that have been deprecated for more than a year

h/t to @samsinsane for original PR on which this is based (#741)
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I did not notice the messages weren't there, my bad. Perhaps the messages could allow for function calls when they're a bit more complex like buildrule, but maybe buildrule is the only one.

@samsinsane samsinsane merged commit 21c3c3d into premake:master Apr 14, 2017
@starkos starkos deleted the fix-missing-deprecation-messages branch August 2, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants