Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed erroneous escape usages in VS2010+ #746

Merged
merged 3 commits into from
Apr 24, 2017
Merged

Fixed erroneous escape usages in VS2010+ #746

merged 3 commits into from
Apr 24, 2017

Conversation

samsinsane
Copy link
Member

  • Added tests for sensible escape usage locations (defines, not undefines or warnings)

Resolves #725

@samsinsane
Fixed erroneous escape usages in VS2010+
dfee2c0 
- Added tests for sensible escape usage locations (defines, not undefines or warnings)
@tvandijck
Copy link
Contributor

not sure I understand why the p.esc call is removed? why is that wrong? is m.element already escaping everything?

@samsinsane
Copy link
Member Author

Yeah, m.element calls p.esc on the third parameter if there are only three parameters.

@tvandijck
Copy link
Contributor

thanks for adding tests too... good to merge.

@tvandijck tvandijck merged commit 53d83df into premake:master Apr 24, 2017
@samsinsane samsinsane deleted the ssurtees/vs2010EscapeFixes branch April 25, 2017 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvandijck tvandijck tvandijck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsinsane @tvandijck @starkos