Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added synchronous and C-Throw to VS projects. #931

Merged
merged 3 commits into from
Oct 19, 2017
Merged

Added synchronous and C-Throw to VS projects. #931

merged 3 commits into from
Oct 19, 2017

Conversation

hatcat
Copy link
Contributor

@hatcat hatcat commented Oct 17, 2017

No description provided.

@tvandijck
Copy link
Contributor

Awesome.. thank you.... For what it is worth... you don't have to close and make a new pull request. When you push your updated branch to the same branch as the existing pull request (master in your case), the pull request will automatically update. That way it also keeps prior discussions and reviews in the same context.

@tvandijck
Copy link
Contributor

tvandijck commented Oct 17, 2017

An on another note, it is often easier to make pull requests from side branches...
that way it is easier to keep your master in sync with the official master. It's obviously up to you to pick your workflow, but I found that making a clean branch from the official master, and then 'cherry-pick' the changes I want to commit as a pull request into that new branch, it is easier to update those branches and fix things in isolation. It also allows you to make multiple pull requests at once.

there is some good info here btw:
https://guides.github.com/

@hatcat
Copy link
Contributor Author

hatcat commented Oct 18, 2017

Yes, I really need to bite the bullet and RTFM for git and github. BRB...

@tvandijck tvandijck merged commit 66362c0 into premake:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants