Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix context.addFilter #958

Merged
merged 1 commit into from
Nov 30, 2017
Merged

fix context.addFilter #958

merged 1 commit into from
Nov 30, 2017

Conversation

tvandijck
Copy link
Contributor

this prevent 'non-strings' from entering the filter/criteria code, which actually crashes the C code.

TurkeyMan
TurkeyMan approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@TurkeyMan TurkeyMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvandijck tvandijck merged commit 4be1372 into premake:master Nov 30, 2017
@tvandijck tvandijck deleted the fix-context-addfilter branch November 30, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurkeyMan TurkeyMan TurkeyMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvandijck @TurkeyMan