Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove children autofocus & add Text Input focus #47

Merged
merged 11 commits into from
Feb 13, 2020
Merged

Conversation

PierreCrb
Copy link
Contributor

@PierreCrb PierreCrb commented Feb 12, 2020

Related to #43

Copy link
Contributor

@tlenclos tlenclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some fix

src/core/models/app.ts Outdated Show resolved Hide resolved
src/core/models/app.ts Outdated Show resolved Hide resolved
src/core/models/app.ts Outdated Show resolved Hide resolved
src/core/selectors/app.ts Outdated Show resolved Hide resolved
src/core/selectors/app.ts Outdated Show resolved Hide resolved
src/hooks/useInteractive.ts Outdated Show resolved Hide resolved
src/hooks/useInteractive.ts Outdated Show resolved Hide resolved
src/hooks/useInteractive.ts Outdated Show resolved Hide resolved
src/hooks/useInteractive.ts Outdated Show resolved Hide resolved
@@ -16,12 +17,14 @@ export const useInteractive = (
const showLayout = useSelector(getShowLayout)
const isComponentSelected = useSelector(getIsSelectedComponent(component.id))
const isHovered = useSelector(getIsHovered(component.id))
const focusInput = useSelector(getInputTextFocused)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const focusInput = useSelector(getInputTextFocused)
const focusInput = useSelector(getFocusedComponent(component.id))

src/hooks/useInteractive.ts Outdated Show resolved Hide resolved
src/hooks/useInteractive.ts Outdated Show resolved Hide resolved
Copy link
Member

@baptadn baptadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good UX move 👍

@tlenclos tlenclos merged commit e2665eb into master Feb 13, 2020
@tlenclos tlenclos deleted the feature/focus branch February 13, 2020 15:39
Batiste1998 added a commit to Wappizy/openchakra that referenced this pull request Aug 27, 2024
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Dec 4, 2024
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Dec 4, 2024
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants