-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove children autofocus & add Text Input focus #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some fix
9d73535
to
28d45b3
Compare
src/hooks/useInteractive.ts
Outdated
@@ -16,12 +17,14 @@ export const useInteractive = ( | |||
const showLayout = useSelector(getShowLayout) | |||
const isComponentSelected = useSelector(getIsSelectedComponent(component.id)) | |||
const isHovered = useSelector(getIsHovered(component.id)) | |||
const focusInput = useSelector(getInputTextFocused) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const focusInput = useSelector(getInputTextFocused) | |
const focusInput = useSelector(getFocusedComponent(component.id)) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Good UX move 👍
Related to #43