Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove isort warning for -rc #86

Merged
merged 2 commits into from
Apr 18, 2024
Merged

remove isort warning for -rc #86

merged 2 commits into from
Apr 18, 2024

Conversation

chinskiy
Copy link
Member

https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0.html

Prior to version 5.0.0, isort wouldn't automatically traverse directories. The --recursive option was necessary to tell it to do so. In 5.0.0 directories are automatically traversed for all Python files, and as such this option is no longer necessary and should simply be removed.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (a174550) to head (fdf3c6e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files           8        8           
  Lines         207      207           
=======================================
  Hits          176      176           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinskiy chinskiy merged commit 6a7b26a into master Apr 18, 2024
14 checks passed
@chinskiy chinskiy deleted the isort_fix branch April 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant