Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update firebase emulator recipe #1030

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

tzkz
Copy link
Contributor

@tzkz tzkz commented Jul 21, 2023

Description

Node prefers ipv6 from version 17 nodejs/node#40537

Screenshots (if appropriate)

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1030 (9a9cdd8) into main (53ee14f) will increase coverage by 0.00%.
The diff coverage is 88.23%.

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   87.27%   87.28%           
=======================================
  Files           6        6           
  Lines         283      291    +8     
  Branches      102      110    +8     
=======================================
+ Hits          247      254    +7     
- Misses         10       11    +1     
  Partials       26       26           
Impacted Files Coverage Δ
src/firebase-utils.ts 83.96% <55.55%> (-0.80%) ⬇️
src/attachCustomCommands.ts 88.15% <100.00%> (ø)
src/extendWithFirebaseConfig.ts 100.00% <100.00%> (ø)
src/plugin.ts 100.00% <100.00%> (ø)
src/tasks.ts 87.20% <100.00%> (+0.95%) ⬆️

@prescottprue
Copy link
Owner

Great catch, thanks for the PR! Will for sure save folks time

@prescottprue prescottprue merged commit 2d8a1a9 into prescottprue:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants