Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): support for tenants in cy.login #436

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

tobiasf
Copy link
Contributor

@tobiasf tobiasf commented Aug 3, 2021

Closes #194, closes #201

Description

Add support for tenants. This PR is a continuation of #201. The only change from #201 is that it's up to date with master and I've fixed the tests.

Tested it locally in my project, and it works as intended!

@prescottprue Let me know if you need something else from this PR for it to be merged

@prescottprue prescottprue changed the base branch from master to v2.1.0 November 29, 2021 02:33
@prescottprue prescottprue changed the title Support for tenants in cy.login feat(commands): support for tenants in cy.login Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #436 (8266f38) into v2.1.0 (f3f7501) will increase coverage by 0.20%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.1.0     #436      +/-   ##
==========================================
+ Coverage   82.19%   82.39%   +0.20%     
==========================================
  Files           7        7              
  Lines         292      301       +9     
  Branches      105      108       +3     
==========================================
+ Hits          240      248       +8     
  Misses         12       12              
- Partials       40       41       +1     
Impacted Files Coverage Δ
src/tasks.ts 71.79% <50.00%> (-0.58%) ⬇️
src/attachCustomCommands.ts 85.52% <100.00%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f7501...8266f38. Read the comment docs.

@prescottprue prescottprue merged commit d3430b7 into prescottprue:v2.1.0 Nov 29, 2021
@prescottprue prescottprue mentioned this pull request Nov 29, 2021
prescottprue added a commit that referenced this pull request Nov 29, 2021
* feat(core): add support for passing app instance (#499) - @zymotik (#506)
* feat(commands): support for tenants in cy.login (#194, #201, #436) - @jonespen, @tobiasf
* fix(callFirestore): apply query settings for collection delete action (#501)
* fix(docs): update code example for Firebase Web SDK version 9 (#466) - @shiiinji
* fix(docs): update config override example in README - @kooba
* fix(core): only include database URL in log if it is set
* fix(core): switch to type imports from firebase-admin (instead of using `import`)
* chore(ci): switch to setup-node for yarn cache in place of a separate step
* chore(dev-deps): update size-limit from v3 to v7
* chore(dependabot): update dependabot commit config to match semantic-relelase
* chore(deps-dev): bump @types/node from 15.3.0 to 16.11.9 (#502) 
* chore(deps-dev): bump @typescript-eslint/eslint-plugin (#482)
* fix(deps): bump path-parse from 1.0.6 to 1.0.7 (#449)
* fix(deps): bump tar from 4.4.13 to 4.4.19 (#461) 
* chore(deps-dev): bump ts-node from 10.0.0 to 10.4.0 (#493) 

Co-authored-by: shiiinji <shinji.toys@gmail.com>
Co-authored-by: Jakub Borys <jakub.borys@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tobias Føyn Føyen <tobiasffoyen@gmail.com>
Co-authored-by: Jon Espen Kvisler <jonespen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(auth): tenant support
3 participants