Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Full example for callFirestore #8

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

axacheng
Copy link
Contributor

replace 'add' to be 'set' for fixing callFirestore example

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
replace 'add' to be 'set' for fixing callFirestore example

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@axacheng axacheng changed the title Update README.md Add Full example for callFirestore Jan 27, 2019
@prescottprue
Copy link
Owner

I love adding examples, thanks for making the PR!

@prescottprue prescottprue merged commit e2c2f46 into prescottprue:master Feb 1, 2019
@prescottprue prescottprue mentioned this pull request Feb 1, 2019
prescottprue added a commit that referenced this pull request Feb 2, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* fix(logout): remove returning of promise (handled by Cypress) - #9
* fix(callFirestore): support calling `update` by passing data - #10, #11 - @bettinatop22
* feat(docs): add full example for `callFirestore` - #7, #8 - @axacheng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants