Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support for collectionGroup query #233

Merged
merged 1 commit into from
Aug 19, 2019
Merged

feat(query): support for collectionGroup query #233

merged 1 commit into from
Aug 19, 2019

Conversation

hiddenchemistry
Copy link

Description

Adds support for collectionGroup queries.

I don’t feel confident enough to write additional tests so hoping someone else can pick this up.

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@prescottprue
Copy link
Owner

Seems that the build failed due to a lint/prettier issue, not actually an issue with the tests. I'll cleanup, thanks for the PR!

@prescottprue prescottprue changed the base branch from master to v0.9.0 August 19, 2019 05:36
@prescottprue prescottprue merged commit 30542fd into prescottprue:v0.9.0 Aug 19, 2019
prescottprue pushed a commit that referenced this pull request Aug 19, 2019
… array - #230

fix(query): cleanup leftover lint from #233
@prescottprue prescottprue mentioned this pull request Aug 19, 2019
3 tasks
prescottprue added a commit that referenced this pull request Sep 6, 2019
* feat(query): support for collectionGroup query - #233 - @hiddenchemistry
* fix(orderedReducer): `DOCUMENT_MODIFIED` action updates index in array - #230
* fix(statusReducer): `UNSET_LISTENER` action type correctly updates status - @esbenvb
* fix(query): support `FieldPath` within query config - [619 of react-redux-firebase](prescottprue/react-redux-firebase#619)
* chore(deps): update `immer`, `lodash`, and `reduce-reducers`
* chore(deps): update dev dependencies including babel and `eslint`
* chore(core): drop node 6 support for development (due to newer `eslint` and other dev deps)
* chore(ci): add node 12 and remove node 6 from CI version matrix
* chore(eslint): switch eslintrc files to js format
* chore(eslint): replace `eslint-config-airbnb` with `eslint-config-airbnb-base`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants