feat(actions): add MULTIPLE_DOCUMENTS_ADDED event to group doc updates #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open to looking to get this merged if we get the test working again |
|
Would love to have this fixed! It's affecting my project and assuming many other projects too |
prescottprue
reviewed
Mar 1, 2021
| action.payload.forEach(changeAction => { | ||
| set(draft, [key, 'data', changeAction.meta.doc], changeAction.payload.data); | ||
| }) | ||
| return draft; |
There was a problem hiding this comment.
Not postive, but I think we should be returning a copy here
There was a problem hiding this comment.
@prescottprue I was just following the way it's done in other cases. For ex. a few lines above, you modify draft directly. Correct me, if I'm wrong though
prescottprue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
If not relevant to pull request, check off as complete
Relevant Issues
Closes prescottprue/react-redux-firebase#914