Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore support #284

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Add gitignore support #284

merged 1 commit into from
Jan 22, 2017

Conversation

alejandrogallo
Copy link
Contributor

There is gitcommit but not yet a gitignore comment symbol. I think it may come
in handy for those that define the gitignore filetype.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted some of these are out of order, but otherwise all will be fine. Can you please make those changes, then rebase to get rid of the superfluous "merge" commit? Two commits is fine, one for each related group of file types.

@@ -174,6 +174,10 @@ let s:delimiterMap = {
\ 'focexec': { 'left': '-*' },
\ 'form': { 'left': '*' },
\ 'fortran': { 'left': '!' },
\ 'molpro': { 'left': '!' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine, but can you please place them in the list in alphabetic order?

@alejandrogallo
Copy link
Contributor Author

alejandrogallo commented Jan 22, 2017 via email

@alerque alerque merged commit 6072532 into preservim:master Jan 22, 2017
@alerque
Copy link
Member

alerque commented Jan 22, 2017

Thanks @alejandrogallo that makes more sense now.

harish2704 added a commit to harish2704/nerdcommenter that referenced this pull request Mar 11, 2017
* 'master' of https://github.com/harish2704/nerdcommenter:
  Add support for the meson build system. (preservim#289)
  Add multi-line comments for Elm (preservim#283)
  Fix removing space when uncommenting spaced AltDelims multipart comment (preservim#286)
  Add gitignore support (preservim#284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants