Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VCL #516

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add support for VCL #516

merged 1 commit into from
Apr 26, 2023

Conversation

ponkio-o
Copy link
Contributor

alerque
alerque requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. And I do appreciate the whitespace cleanup, but can we please not do that in unrelated commits / PRs? The commit for adding VCL support should only add VCL support. Whitespace cleanup commits should only change whitespace. Even if it is reviewable now, these add up to make git blame and other tooling very difficult to use in the future.

@ponkio-o
Copy link
Contributor Author

@alerque Thank you for your review! I just reverted the unrelated changes.
https://github.com/preservim/nerdcommenter/compare/2a425ef49439574c33fd0202b372f413454457a4..4709b6df1273da3b300c3e466ed4788494f22b8c

@alerque alerque merged commit e23f55e into preservim:master Apr 26, 2023
@alerque
Copy link
Member

alerque commented Apr 26, 2023

Thanks! A separate PR with code style cleanup would be fine by the way.

@ponkio-o ponkio-o mentioned this pull request Apr 26, 2023
Merged
@ponkio-o ponkio-o deleted the add_vcl branch April 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ponkio-o @alerque