Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use :mode only in neovim. MacVim still needs to use :redraw! #1019

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Use :mode only in neovim. MacVim still needs to use :redraw! #1019

merged 5 commits into from
Jul 10, 2019

Conversation

PhilRunninger
Copy link
Member

@PhilRunninger PhilRunninger commented Jul 10, 2019 •
edited
Loading

Description of Changes

As reported in 3b1a850#r34251299, MacVim has the same problem with :mode that neovim has with :redraw! in the NERDtree menu. I made an autoload function that handles both cases (with if has('nvim')), and swapped it in for all the redraw and redraw! statements.

New Version Info

  • Derive a new version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following this format/example: 
    #### MAJOR.MINOR...
- **.PATCH**: PR Title (Author) [#PR Number](link to PR)

#### 5.1...
- **.1**: Update Changelog and create PR Template (PhilRunninger) [#1007](https://github.com/scrooloose/nerdtree/pull/1007)
- **.0**: Too many changes for one patch...

@PhilRunninger PhilRunninger merged commit 4ac07f5 into master Jul 10, 2019
@PhilRunninger PhilRunninger deleted the fix_1016 branch July 10, 2019 13:46
@RobertAudi RobertAudi mentioned this pull request Jul 13, 2019
Closed
15 tasks
PhilRunninger added a commit that referenced this pull request Jul 14, 2019
@PhilRunninger
Revert "Use :mode only in neovim. MacVim still needs to use :redraw! (#…
3f5e63a 
…1019)"

This reverts commit 4ac07f5.
@PhilRunninger PhilRunninger mentioned this pull request Jul 14, 2019
Merged
5 tasks
PhilRunninger added a commit that referenced this pull request Jul 14, 2019
@PhilRunninger
Revert #1019 to fix nvim artifacts and flickering. (#1021)
63c5920 
* Revert "Use :mode only in neovim. MacVim still needs to use :redraw! (#1019)"

This reverts commit 4ac07f5.

* If not Neovim, use `:redraw!` as was done before.

* Update version number.

* Fix punctuation in NERDTree Menu instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PhilRunninger