Suppress events for intermediate window/tab/buffer changes #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 10, 2019 01:32
The value doesn't matter, but 1 is a good choice. Its presence is an indicator that tells NERDTree to tell Vim to ignore all events. I'm not yet sure if there needs to be an else section to that if block. It may be OK to allow all events to fire in the right situations.
Finding all the right function calls is the key here.
wincent
reviewed
Aug 8, 2019
lib/nerdtree/nerdtree.vim
Outdated
| else | ||
| call nerdtree#exec(bufwinnr(l:activeBufOrWin) . " wincmd w") | ||
| call nerdtree#exec(bufwinnr(l:activeBufOrWin) . " wincmd w",0) |
There was a problem hiding this comment.
Looks like you need a space after the , here and two lines above.
lib/nerdtree/opener.vim
Outdated
| exec("silent ". splitMode ." resize ". size) | ||
| call nerdtree#exec('wincmd p') | ||
| call nerdtree#exec('wincmd p',0) |
lib/nerdtree/opener.vim
Outdated
|
|
||
| let l:currentWindowNumber = winnr() | ||
|
|
||
| " Restore the NERDTree to its original width. | ||
| call g:NERDTree.CursorToTreeWin() | ||
| execute 'silent vertical resize ' . l:winwidth | ||
|
|
||
| call nerdtree#exec(l:currentWindowNumber . 'wincmd w') | ||
| call nerdtree#exec(l:currentWindowNumber . 'wincmd w',0) |
lib/nerdtree/opener.vim
Outdated
| @@ -321,7 +321,7 @@ function! s:Opener._reuseWindow() | |||
| "check the current tab for the window | |||
| let winnr = bufwinnr('^' . self._path.str() . '$') | |||
| if winnr != -1 | |||
| call nerdtree#exec(winnr . "wincmd w") | |||
| call nerdtree#exec(winnr . "wincmd w",0) | |||
lib/nerdtree/opener.vim
Outdated
| let winnr = bufwinnr('^' . self._path.str() . '$') | ||
| call nerdtree#exec(winnr . "wincmd w") | ||
| call nerdtree#exec(winnr . "wincmd w",0) |
lib/nerdtree/ui.vim
Outdated
| let b:NERDTreeZoomed = 0 | ||
| else | ||
| exec "vertical resize ". get(g:, 'NERDTreeWinSizeMax', '') | ||
| call nerdtree#exec("vertical resize ". get(g:, 'NERDTreeWinSizeMax', ''),1) |
nerdtree_plugin/fs_menu.vim
Outdated
| exec "tabnext " . s:originalTabNumber | ||
| exec s:originalWindowNumber . "wincmd w" | ||
| call nerdtree#exec("tabnext " . s:originalTabNumber,1) | ||
| call nerdtree#exec(s:originalWindowNumber . "wincmd w",1) |
nerdtree_plugin/fs_menu.vim
Outdated
| @@ -141,17 +141,17 @@ function! s:renameBuffer(bufNum, newNodeName, isDirectory) | |||
| let editStr = g:NERDTreePath.New(a:newNodeName).str({'format': 'Edit'}) | |||
| endif | |||
| " 1. ensure that a new buffer is loaded | |||
| exec "badd " . quotedFileName | |||
| call nerdtree#exec("badd " . quotedFileName,1) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #588
Got rid of the line that always ignores the
BufEnter,BufLeave, andVimEnterevents. So now, no events are ignored, and this allowsBufEnterto be fired when opening an already open file, fixing #588.But not so fast.....
Closes #684
The change above causes events to be fired way more often than necessary because of NERDTree's need to switch windows at various times. To solve this, a new parameter was added to
nerdtree#exec()that can cause all events to be ignored. This is set to 1 for all the intermediate window switches, and then to 0 for the final window switch to the selected file. This change, which comprises many lines of code throughout NERDTree, fixes the ping-ponging that was mentioned in #684 but has, until now, been left unaddressed.New Version Info
MAJORversion when you make incompatible API changesMINORversion when you add functionality in a backwards-compatible mannerPATCHversion when you make backwards-compatible bug fixes