Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce necessary variable mistakenly removed. #1040

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Conversation

PhilRunninger
Copy link
Member

@PhilRunninger PhilRunninger commented Sep 26, 2019

Description of Changes

Closes #1039

let splitMode =... was removed, but is still needed, in the 6.0.0 release. This PR adds it back in.


New Version Info

  • Derive a new version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.
  • Tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

@PhilRunninger PhilRunninger merged commit 5af6859 into master Sep 26, 2019
@PhilRunninger PhilRunninger deleted the 1039 branch September 26, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined variable: splitMode
1 participant