Add the ability to turn off directory arrows #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2020 01:58
Also improved some highlighting to make use of g:NERDTreeNodeDelimiter, which directly surrounds the filename. More of this to come as errors are tracked down and fixed in this file.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/nerdtree/tree_dir_node.vim
Outdated
| let l:symbol = g:NERDTreeDirArrowExpandable | ||
| endif | ||
|
|
||
| let l:padding = g:NERDTreeDirArrowExpandable == '' ? '' : ' ' |
There was a problem hiding this comment.
[vint] reported by reviewdog 🐶
Use robust operators ==# or ==? instead of == (see Google VimScript Style Guide (Matching))
lib/nerdtree/tree_file_node.vim
Outdated
|
|
||
| if !self.path.isDirectory | ||
| let treeParts = treeParts . ' ' | ||
| if !self.path.isDirectory && g:NERDTreeDirArrowExpandable != '' |
There was a problem hiding this comment.
[vint] reported by reviewdog 🐶
Use robust operators !=# or !=? instead of != (see Google VimScript Style Guide (Matching))
syntax/nerdtree.vim
Outdated
| exec 'syn match NERDTreeDir #[^'.s:dirArrows.' ].*/#' | ||
| syn match NERDTreeExecFile '^ .*\*\($\| \)' contains=NERDTreeRO,NERDTreeBookmark | ||
| exec 'syn match NERDTreeFile #^[^"\.'.s:dirArrows.'] *[^'.s:dirArrows.']*# contains=NERDTreeLink,NERDTreeRO,NERDTreeBookmark,NERDTreeExecFile' | ||
| if g:NERDTreeDirArrowExpandable != '' |
There was a problem hiding this comment.
[vint] reported by reviewdog 🐶
Use robust operators !=# or !=? instead of != (see Google VimScript Style Guide (Matching))
added 5 commits
February 3, 2020 02:28
PhilRunninger
pushed a commit
to PhilRunninger/nerdtree-buffer-ops
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #1064
Directory arrows can now be turned off. Formerly it was possible to turn the arrows into a non-breaking space, but this is different in that the entire tree is shifted to the left two character positions by removing the arrow and the space that follows it.
New Version Info
Author's Instructions
MAJOR.MINOR.PATCHversion number. Increment the:MAJORversion when you make incompatible API changesMINORversion when you add functionality in a backwards-compatible mannerPATCHversion when you make backwards-compatible bug fixesCollaborator's Instructions
git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags