Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add] How to install using dein.vim #1087

Merged
merged 1 commit into from
Feb 7, 2020
Merged

[add] How to install using dein.vim #1087

merged 1 commit into from
Feb 7, 2020

Conversation

get-me-power
Copy link
Contributor

@get-me-power get-me-power commented Feb 7, 2020 •
edited by PhilRunninger
Loading

Description of Changes

Hi, maintainer.
I added how to install using dein.vim.
Could you check this Pull Request?

Reference

https://github.com/Shougo/dein.vim

New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

PhilRunninger
PhilRunninger requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also update CHANGELOG.md to increment the version number? This will be version 6.6.1.

@get-me-power
Copy link
Contributor Author

get-me-power commented Feb 7, 2020 •
edited
Loading

@PhilRunninger
Thanks for review.
I updated CHANGELOG.md.

@PhilRunninger PhilRunninger merged commit 7a0312f into preservim:master Feb 7, 2020
@get-me-power get-me-power deleted the add_dein_in_README branch February 7, 2020 19:04
@get-me-power
Copy link
Contributor Author

@PhilRunninger
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilRunninger PhilRunninger PhilRunninger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@get-me-power @PhilRunninger