Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Move: Escape existing directory name when looking for open files. #1094

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

PhilRunninger
Copy link
Member

@PhilRunninger PhilRunninger commented Mar 23, 2020

Description of Changes

Closes #1093

When a directory is renamed, all open buffers are examined to see if they live in that directory. If any such files are open, the user is asked if the files should be renamed/reopened. The problem raised in the issue is caused by said examination. The string does not have its backslashes escaped, which causes a numbered subdirectory, \2 for example, to be treated as a regex back reference, which doesn't exist. The solution is to make sure the backslashes are escaped before doing this examination.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

@PhilRunninger PhilRunninger merged commit 495b4e7 into master Mar 24, 2020
@PhilRunninger PhilRunninger deleted the 1093 branch March 24, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] rename dir failed (E65: illegal back reference) when path contains number
1 participant