Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vsplit to not open empty buffer #1098

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

AwkwardKore
Copy link
Contributor

@AwkwardKore AwkwardKore commented Apr 1, 2020

Description of Changes

Closes #1097


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

@PhilRunninger
Copy link
Member

@AwkwardKore , it looks good. Please add a new entry in CHANGELOG.md for this pull request. This will be version 6.7.3. Follow the established pattern.

@PhilRunninger PhilRunninger self-requested a review April 1, 2020 05:14
Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

@PhilRunninger PhilRunninger self-requested a review April 1, 2020 05:21
@PhilRunninger PhilRunninger merged commit 832bbaa into preservim:master Apr 1, 2020
@AwkwardKore
Copy link
Contributor Author

@PhilRunninger Thanks! It was a pleasure to help 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty buffer is created when using vsplit(s) on a previously opened and closed file.
2 participants