Prevent unneeded tree creation in :NERDTreeToggle[VCS] <path> #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/nerdtree/creator.vim
Outdated
| @@ -366,7 +366,8 @@ function! s:Creator.toggleTabTree(dir) | |||
| if g:NERDTree.ExistsForTab() | |||
| if !g:NERDTree.IsOpen() | |||
| call self._createTreeWin() | |||
| if !empty(a:dir) | |||
| let l:currentPath = getbufvar(t:NERDTreeBufName,"NERDTree").root.path.str() | |||
There was a problem hiding this comment.
[vint] reported by reviewdog 🐶
Prefer single quoted strings (see Google VimScript Style Guide (Strings))
PhilRunninger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #1100
NERDTreeToggleVCSworks by finding the root of the repository and passing it to theNERDTreeToggle <path>function. Pull request #1083 changed the wayNERDTreeToggleworks, such that when a path is specified, the NERDTree's root is always set to that path. The NERDTree is collapsed as it always is when setting a new root.This pull request tempers that behavior. If the path given (the repo's root in this case) is the same as the current NERDTree root, then don't recreate the tree.
New Version Info
Author's Instructions
MAJOR.MINOR.PATCHversion number. Increment the:MAJORversion when you make incompatible API changesMINORversion when you add functionality in a backwards-compatible mannerPATCHversion when you make backwards-compatible bug fixesCollaborator's Instructions
git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags